Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Switch to `bencode` for much faster bencoding #124

Closed
feross opened this issue Sep 21, 2014 · 4 comments
Closed

[CLOSED] Switch to `bencode` for much faster bencoding #124

feross opened this issue Sep 21, 2014 · 4 comments

Comments

@feross
Copy link
Member

@feross feross commented Sep 21, 2014

Issue by feross
Thursday Jun 12, 2014 at 00:49 GMT
Originally opened as https://github.com/feross/bittorrent-client/issues/28

bencode claims to be much faster than bncode (what we currently use in all webtorrent modules).

  • 30x faster decoding
  • 2x faster encoding

Need to change:

  • bittorrent-tracker
  • bittorrent-dht
  • ut_pex
  • ut_metadata
  • parse-torrent
  • bittorrent-protocol
  • create-torrent
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Thursday Jun 12, 2014 at 01:01 GMT

This is done -- just waiting on ut_pex PR from @fisch0920 before closing this.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by fisch0920
Thursday Jun 12, 2014 at 01:49 GMT

Looks good!
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Thursday Jun 12, 2014 at 01:50 GMT

Cool, feel free to close this issue when you've published a new version of ut_pex.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by fisch0920
Thursday Jun 12, 2014 at 01:55 GMT

Published ut_pex v1.0.1
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.