Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to update the blocklist without restarting #1241

Open
anthonybriand opened this issue Dec 12, 2017 · 3 comments
Open

No way to update the blocklist without restarting #1241

anthonybriand opened this issue Dec 12, 2017 · 3 comments

Comments

@anthonybriand
Copy link

@anthonybriand anthonybriand commented Dec 12, 2017

What version of WebTorrent?
0.98.20
What operating system and Node.js version?
MacOS X 10.13 / Node.JS 8.9.1
What did you expect to happen?
A way to update the blocklist programmaticaly without restarting the client
What actually happened?
Nothing because no method is available

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 12, 2017

I'm lost. What's the blocklist?

@anthonybriand

This comment has been minimized.

Copy link
Author

@anthonybriand anthonybriand commented Dec 13, 2017

Sorry I wasn't clear, it's corresponding to the loaded ipSet, cf code block:

webtorrent/index.js

Lines 149 to 161 in 0bf7b97

if (typeof loadIPSet === 'function' && opts.blocklist != null) {
loadIPSet(opts.blocklist, {
headers: {
'user-agent': 'WebTorrent/' + VERSION + ' (https://webtorrent.io)'
}
}, function (err, ipSet) {
if (err) return self.error('Failed to load blocklist: ' + err.message)
self.blocked = ipSet
ready()
})
} else {
process.nextTick(ready)
}

It would be important to be able to update periodically or on demand the ipSet blocklist without restarting the client

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 30, 2018

Fair point, once WebTorrent Desktop exposes this functionality in Preferences, we'll probably need this functionality.

@feross feross added enhancement accepted and removed accepted labels Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.