Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render-media appendTo callback not fired #1250

Closed
Weedshaker opened this issue Dec 23, 2017 · 2 comments
Closed

render-media appendTo callback not fired #1250

Weedshaker opened this issue Dec 23, 2017 · 2 comments
Labels

Comments

@Weedshaker
Copy link

@Weedshaker Weedshaker commented Dec 23, 2017

What version of WebTorrent?
webtorrent@0.98.20

What operating system and Node.js version?
Ubuntu 16.04, Node.js v8.1.3

What browser and version? (if using WebTorrent in the browser)
FF 57.0.1, Chrome 63.0.3239.108

What did you expect to happen?
appendTo video shall fire a callback when appended

What actually happened?
the callback does not get fired when opt is autoplay: false in FireFox and Chrome. Though it works in Chromium. I don't know if the newer version of render-media fixes this issue.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented May 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 3, 2018
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 4, 2018

This bug was likely due to changes in how most browsers handle autoplaying video with audio. Videos that attempt to autoplay with audio are not allowed to play anymore. More details: https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

The render-media library has been updated to account for this change. Now the callback is called when the <video> tag emits 'canplay' instead of 'timeupdate'.

💪

@feross feross closed this May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.