Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 0.98.20; asm.js warning is back #1252

Closed
norzak opened this issue Dec 25, 2017 · 4 comments
Closed

Regression in 0.98.20; asm.js warning is back #1252

norzak opened this issue Dec 25, 2017 · 4 comments

Comments

@norzak
Copy link

@norzak norzak commented Dec 25, 2017

Both Chrome and Firefox give asm.js warning in 0.98.20. The 0.98.19 does not give the warning.
@norzak

This comment has been minimized.

Sign in to view
Copy link
Author

@norzak norzak commented Dec 26, 2017

#281
@stale

This comment has been minimized.

Sign in to view
Copy link

@stale stale bot commented May 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 3, 2018
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented May 4, 2018

This is not an issue anymore. I just checked Chrome and Firefox now. This issue must have resolved itself in a browser update, or perhaps when we updated the babel-minify minifier that we use.
@feross feross closed this May 4, 2018
@stale stale bot removed the stale label May 4, 2018
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented May 4, 2018

Nevermind - just confirmed it. It only happens with the webtorrent.min.js. This must be an artifact of using babel-minify on the JavaScript.

It's not harmful, so I'm still going to keep this issue closed. If you want to fix the issue upstream in babel-minify that would be great.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@norzak @feross
You can’t perform that action at this time.