Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAccess-Control-Allow-Methods should be GET,HEAD #1267
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
++ |
This comment has been minimized.
This comment has been minimized.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This comment has been minimized.
This comment has been minimized.
|
Just sent a PR for this: #1383 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the webtorrent server, the
Access-Control-Allow-Methodsheader should not set it's value toGET,HEAD,PUT,PATCH,POST,DELETEsince onlyGET,HEADare actually handled. Any other request type is rejected by the server with an "invalid method" error.Let's pare down the list for defense-in-depth reasons. No reason to let cross-origin domains even send these requests in the first place.
@diracdeltas