Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[CLOSED] verifying chunks is very slow #128
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
@vikstrous You're correct. No need to use rusha. We'll just use the built-in crypto library which is likely fastest in node. I just changed out all uses of Rusha in parse-torrent, bittorrent-dht, ut_metadata, and this module to use crypto. For the modules that run in the browser, like parse-torrent, I might selectively include rusha if the shim that browserify uses isn't fast enough. |
This comment has been minimized.
This comment has been minimized.
|
Fixed in https://github.com/feross/bittorrent-client/commit/fcdf1f229d0d1f97964e8a057e59a1eb23f8c612 and published as 0.3.2. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Saturday Jun 14, 2014 at 01:45 GMT
Originally opened as https://github.com/feross/bittorrent-client/issues/32
I think this is because of the use of Rusha. Why not just use the native crypto library? Rusha can't possibly be faster in node.js right? I looked at Rusha's github repo and they don't have any benchmarks comparing against the crypto library.