Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock origin plugin causes peer discovery to fail #1292

Closed
chr15m opened this issue Feb 14, 2018 · 6 comments
Closed

uBlock origin plugin causes peer discovery to fail #1292

chr15m opened this issue Feb 14, 2018 · 6 comments

Comments

@chr15m
Copy link
Contributor

@chr15m chr15m commented Feb 14, 2018

This was not always the case but it seems that the uBlock Origin plugin is now blocking websocket connections to the default set of trackers.

Not sure if this should be considered a bug or not but these days quite a lot of people run ad-blocking plugins. According to the Wikipedia page on uBlock Origin:

the uBlock Origin Chrome extension has more than 10 million active users, and the Firefox version has more than 5 million active users.

What version of WebTorrent?

v0.98.21

What browser and version? (if using WebTorrent in the browser)

Firefox 58.0.1 on GNU/Linux.

What did you expect to happen?

Successful connection (screenshot is from Chrome without uBlock Origin running).

chrome-webtorrent

What actually happened?

Only peer connected is self (screenshot is from Firefox on the same machine with uBlock Origin running).

firefox-webtorrent

Here is the set of domains uBlock Origin is blocking:

ublock-origin

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Feb 15, 2018

What's your config like? I don't see them blocked

@chr15m

This comment has been minimized.

Copy link
Contributor Author

@chr15m chr15m commented Feb 16, 2018

@DiegoRBaquero my config is the default, I haven't modified it. Is yours modified?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Feb 16, 2018

Wow, I see this too now. The following rules are preventing connections to the default set of tracker servers:

.xyz^$third-party,websocket
||fastcast.nz^$third-party
||tracker.openwebtorrent.com^$third-party

I just opened an issue on the uBlock Origin tracker here: uBlockOrigin/uAssets#1557 Will close this issue now.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Feb 16, 2018

Both uBlock Origin and the EasyList maintainers have added exceptions for WebTorrent. ❤️

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Feb 18, 2018

It seems they only unblocked in webtorrent.io (?) fastcast and openwebtorrent trackers won't work in btorrent.xyz

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Feb 20, 2018

The commit is here: easylist/easylist@6cabf98

It's not 100% clear what they changed. I think they unblocked the fastcast and openwebtorrent trackers. But they continued blocking third-party and websocket connections to all .xyz domains, except if you're on webtorrent.io.

So, maybe that means that btorrent.xyz users can still access tracker.btorrent.xyz because that's "first party" (on the same site). But it definitely seems that tracker.btorrent.xyz will be blocked from all domains that are not webtorrent.io and btorrent.xyz in uBlock Origin.

I think blocking all .xyz domains is quite broad. I wonder why they're doing that... I bet you could open another issue about it.

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.