Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofind subtitles #1378

Closed
odahcam opened this issue May 5, 2018 · 5 comments
Closed

Autofind subtitles #1378

odahcam opened this issue May 5, 2018 · 5 comments
Labels

Comments

@odahcam
Copy link

@odahcam odahcam commented May 5, 2018

This is a feature-request

What did you expect to happen?

I want to click on the subtitles button and the player antumatically searches for subtitles for the video I'm playing. This behavior can be found in bitLord client, which has awesome features and terrible performance and UX.

What actually happened?

I can only add subtitles files.

Also interesting

VLC player has a searcher that searches for subtitles on the web, but BitLord's one is by far better than anything I've ever used. That's an awesome feature and I'd like to see that in here.

@feross feross added the question label May 9, 2018
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 9, 2018

We're unlikely to add a feature like this because it's unclear whether using subtitles like this is okay. However, can you link to a webpage that explains how this VLC functionality works so I can read about it?

@feross feross closed this May 9, 2018
@odahcam

This comment has been minimized.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 10, 2018

Hmm, if VLC is shipping this now, then let's consider it. Leaving this open to remind me to look into it.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 10, 2018

Oh, this belongs on the webtorrent-desktop issue tracker: webtorrent/webtorrent-desktop#1383

@feross feross closed this May 10, 2018
@odahcam

This comment has been minimized.

Copy link
Author

@odahcam odahcam commented May 10, 2018

Very nice, thanks.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.