Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of bittorrent-dht is breaking the build 🚨 #1401

Closed
greenkeeper bot opened this issue May 23, 2018 · 2 comments
Closed

An in-range update of bittorrent-dht is breaking the build 🚨 #1401

greenkeeper bot opened this issue May 23, 2018 · 2 comments
Labels

Comments

@greenkeeper
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 23, 2018

Version 8.4.0 of bittorrent-dht was just published.

Branch Build failing 🚨
Dependency bittorrent-dht
Current Version 8.3.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

bittorrent-dht is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build is in progress Details
  • continuous-integration/appveyor/branch AppVeyor build failed Details

Commits

The new version differs by 14 commits.

  • 9daa994 8.4.0
  • 912eec8 npmignore
  • 88f408a bin/ -> tools/
  • b552496 Merge pull request #190 from chr15m/issue-167-comply-with-bep44-salt-spec
  • 1bfffdc Merge branch 'master' into issue-167-comply-with-bep44-salt-spec
  • ac3f8cb Merge pull request #155 from thomasyuan/master
  • 471ab3f Merge pull request #195 from chr15m/issue-194-ignore-cache-get-mutable-option
  • 667dca9 Updated documentation with notes about salt. #167
  • c21a13e Do not send salt in mutable get response. #167
  • 9fa9710 Allow user to specify mutable get salt in opts. #167
  • f057b3c Option to use/ignore cached value in mutable get.
  • cffd30e fix test.
  • 8011a14 remove unnecessary check.
  • 346759b don't cache mutable value since it could be changed by other peers.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label May 23, 2018
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented May 23, 2018

After pinning to 8.3.0 your tests are passing again. Downgrade this dependency 📌.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 23, 2018

False alarm. It looks like AppVeyor didn't see that 8.4.0 was published yet. Some kind of eventual consistency issue.

@feross feross closed this May 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.