Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Remove airtap #1445

Closed
feross opened this issue Jul 27, 2018 · 1 comment
Closed

Meta: Remove airtap #1445

feross opened this issue Jul 27, 2018 · 1 comment
Labels
enhancement meta

Comments

@feross
Copy link
Member

@feross feross commented Jul 27, 2018 •
edited

Let's remove airtap from webtorrent dependencies which we control and which do not use DOM APIs, since there's not much benefit to doing browser testing on those packages and it will improve test reliability quite a lot.

Let's keep airtap in the top-level webtorrent package

  • bittorrent-protocol
  • [ ] bittorrent-tracker (uses websockets)
  • [ ] render-media (uses DOM APIs)
  • create-torrent
  • magnet-uri
  • parse-torrent
  • string2compact
  • ut_metadata

Remember to remove:

  • .airtap.yml
  • Sauce settings in .travis.yml
  • Sauce Labs readme badge
  • dependency in package.json
  • scripts in package.json
  • ignore from .npmignore
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Jul 27, 2018

All done! 🎉
@feross feross closed this Jul 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement meta
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.