Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support electron render and cordova #1502

Closed
pinghe opened this issue Sep 11, 2018 · 2 comments
Closed

[feature] support electron render and cordova #1502

pinghe opened this issue Sep 11, 2018 · 2 comments
Labels

Comments

@pinghe
Copy link

@pinghe pinghe commented Sep 11, 2018

WebTorrent supports both nodejs and browser environments. Determine whether it is nodejs by the true or false of the typeof fs.stat === function condition. This is not enough. In the electron render process, both webrtc and fs can be supported. The cordova environment can support both webrtc and cordova-plugin-file.

Organize the following list, expecting supported environment features

seed nodejs electron main electron render cordova(file plugin) browser
condition window === 'undefined' window === 'undefined' window.process && window.process.versions && window.process.versions.electron window._cordovaNative ¦¦ window.cordova
filesystem path to file or folder y y y y n
W3C File object n n y y y
W3C FileList object n n y y y
Node Buffer object y y y y y
Node Readable stream object y y y y y
WEBRTC n n y y y
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Dec 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 10, 2018
@stale stale bot closed this Dec 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2019
@webtorrent webtorrent unlocked this conversation Sep 5, 2019
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 5, 2019

@pinghe Thanks for opening this issue and for the detailed support table. Can you share what bug you experiencing in Electron or Cordova? We use WebTorrent in Electron for https://github.com/webtorrent/webtorrent-desktop without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.