Don't wait timeout on http failure (webseed)

[Chocobozzz]

What version of WebTorrent?
0.102.1

What operating system and Node.js version?
Browser

What browser and version? (if using WebTorrent in the browser)
Chromium 69

What did you expect to happen?

With a torrent having 2 webseed endpoints, if 1 webseed fails to respond webtorrent should not wait wire timeout before getting the chunk on the other webseed.

What actually happened?

Webtorrent waits the wire timeout (~30 seconds), and then get the chunk from the other http endpoint. Could be annoying when we want to stream the torrent file in a video element.

The wire get the error here but do nothing (do not call the callback with an error as argument for example): https://github.com/webtorrent/bittorrent-protocol/blob/master/index.js#L496

And so we get the timeout here: https://github.com/webtorrent/bittorrent-protocol/blob/master/index.js#L565

Could we call the callback directly in the _onRequest function so we don't have to wait 30 seconds?

PS: Maybe it's the wrong repository for this issue, but I'm not sure where we should handle this case.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Chocobozzz]

Don't

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Chocobozzz]

Please remove the stale bot, I don't want to comment my issues every 3 months. It has already closed several interesting issues.

[DiegoRBaquero]

The way to do it is to add labels. See https://github.com/webtorrent/webtorrent/blob/master/.github/stale.yml

[feross]

Please remove the stale bot, I don't want to comment my issues every 3 months. It has already closed several interesting issues.

Sorry about that @Chocobozzz. The idea is to auto close the tons of silly / half-baked issues that we constantly get. If we apply labels to the interesting issues, they will stay open. I just added you to the WebTorrent organization so you can help add appropriate labels.

As I've been catching up on all my GitHub notification emails from the past months, I've been re-opening any issues that shouldn't have been closed.

I also just increased the stale timeout to 180 days from 90 days.

[Chocobozzz]

Thanks @feross, very happy to see you back :)