Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxBlobLength is ignored #1512

Closed
index23 opened this issue Sep 20, 2018 · 2 comments
Closed

MaxBlobLength is ignored #1512

index23 opened this issue Sep 20, 2018 · 2 comments

Comments

@index23
Copy link

@index23 index23 commented Sep 20, 2018

What version of WebTorrent?
I am using WebTorrent version 0.102.4

What browser and version? (if using WebTorrent in the browser)
I am using Chrome version 69.0.3497.100 (Official Build) (64-bit)

What did you expect to happen?
I expect to fail streaming of video.

What actually happened?
Video is streaming normally.

Hi,

I stream video using appendTo method, and through opts parameter I have set maxBlobLength to 1:

file.appendTo('#player-wrapper', {
          autoplay: true,
          controls: false,
          maxBlobLength: 1
        }, (err, elem) => {
          if (err) {
            console.log('Error:', err)
          }
        }) 

Due to documentation,

maxBlobLength: Files above this size will skip the "blob" strategy and fail (default: 200 * 1000 * 1000 bytes)

I have expected to fail streaming of video, video plays normally.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Dec 19, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 19, 2018
@stale stale bot closed this Dec 26, 2018
@DiegoRBaquero DiegoRBaquero reopened this Dec 27, 2018
@stale stale bot removed the stale label Dec 27, 2018
@DiegoRBaquero DiegoRBaquero added the bug label Dec 27, 2018
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 5, 2019

This isn't necessarily a bug. The video you are trying to play may be using the videostream or mediasource strategy in which case the video is being streamed (with low memory usage) and this parameter is ignored. The maxBlobLength parameter is only used when the blob strategy is used, which is attempted after the other two. The option exists to limit the max amount of RAM that will be used to make the Blob.

@feross feross closed this Sep 5, 2019
@feross feross removed the bug label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.