Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Move (most of) WebTorrent into Web Workers #1524

Open
jimmywarting opened this issue Oct 7, 2018 · 4 comments
Open

[Feature request] Move (most of) WebTorrent into Web Workers #1524

jimmywarting opened this issue Oct 7, 2018 · 4 comments

Comments

@jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Oct 7, 2018

Using WebTorrent in the main thread makes the page unresponsive sometimes.
What would it take to move WebTorrent into a web worker?

I know WebRTC is not supported in web workers for example.
So you would have to communicate back and forth with postMessage to handle WebRTC.


Almost feel we need a performance sprint and focus on making WebTorrent faster and CPU friendlier.
Having some benchmark testing would be awesome too.

@Chocobozzz

This comment has been minimized.

Copy link
Contributor

@Chocobozzz Chocobozzz commented Oct 8, 2018

@jimmywarting Did you try this patch?

@jimmywarting

This comment has been minimized.

Copy link
Contributor Author

@jimmywarting jimmywarting commented Oct 8, 2018

Nope, not yet. But it looks like that is just one tiny adjustment (and only for Chrome).
Still think it would be more beneficial to have it all in a web worker

@Chocobozzz

This comment has been minimized.

Copy link
Contributor

@Chocobozzz Chocobozzz commented Oct 8, 2018

Sure, it was just to know if the patch improved your unresponsive issues. (fyi firefox supports requestIdleCallback too)

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Jan 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.