Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src=(unknown) with appendTo() method on chrome #1556

Closed
chisNaN opened this issue Dec 6, 2018 · 10 comments
Closed

src=(unknown) with appendTo() method on chrome #1556

chisNaN opened this issue Dec 6, 2018 · 10 comments

Comments

@chisNaN
Copy link

@chisNaN chisNaN commented Dec 6, 2018

What version of WebTorrent?

webtorrent@latest
as of today

What operating system and Node.js version?

macos mojave

What browser and version? (if using WebTorrent in the browser)

Chrome 71.0.3

What did you expect to happen?

my script was initially working on chrome but stopped to work recently.
It is still working on firefox (and opera)
(obviously only with mp4 files)
What actually happened?

file.appendTo('body')

will make the correct blob value of attribute src
but after several seconds of loading the src will be like this
src=(unknown)

and make the video not playable
capture d ecran 2018-12-06 a 09 54 09

I tried to remove all history of chrome and executing this command:
find ~/Library/Caches/ -type f -name "*" -delete
to be sure i have no cache problem

but still its not working either LOCALLY or on a aws s3 bucket

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 6, 2018

This might be a regression with Chrome 71?

Video starts ? and then src will go unknown and video will stop?

@chisNaN

This comment has been minimized.

Copy link
Author

@chisNaN chisNaN commented Dec 7, 2018

Thanks for your reply.
It maybe a regression due to something changed in chrome...
Actually video never started.
The correct blob was initially written in the src value attribute but after replaced by this unknown
Un cordial saludo Diego (soy franco colombiano)

@chisNaN

This comment has been minimized.

Copy link
Author

@chisNaN chisNaN commented Dec 7, 2018

I confirm that i managed to try with a previous of chrome 70 and i dont have this problem...

@dannylazarow2

This comment has been minimized.

Copy link

@dannylazarow2 dannylazarow2 commented Dec 16, 2018

https://developers.google.com/web/updates/2018/10/chrome-71-deps-rems#remove_urlcreateobjecturl_from_mediastream

Google removed something from media stream.
Videostream package fails silently

I think this is quite a bumper. Videos on 71 does not load

@chisNaN

This comment has been minimized.

Copy link
Author

@chisNaN chisNaN commented Dec 16, 2018

@dannylazarow2 THanks for your reply. So maybe its the feross mediasource package that should be fixed. This file more especially:
mediasource

DiegoRBaquero added a commit to DiegoRBaquero/mediasource that referenced this issue Dec 17, 2018
@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 17, 2018

Sent a PR. We need @feross though.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Dec 18, 2018

This works in Chrome Canary, so it's likely a regression in Chrome itself. To test it, go to https://webtorrent.io in Chrome 71 (streaming doesn't work, falls back to blob approach) and 73 (does work). The deprecation of createObjectURL is only for WebRTC webcam video streams, not for the MediaSource API streams. Thanks to @jhiesey for figuring this out!

feross added a commit to feross/mediasource that referenced this issue Dec 18, 2018
This fixes up the console errors on webtorrent.io right now, but Chrome 71 still doesn't support streaming (webtorrent/webtorrent#1556)
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Dec 18, 2018

@jhiesey said that the file works fine when the audio track is removed from the file. It seems that perhaps Chrome has gotten more strict about rejecting malformed files? I found these recent issues which seem to indicate this:

But it's a good sign that the file works in Canary. Perhaps they reverted the change that caused this issue and this will fix itself in a future Chrome version?

@chisNaN

This comment has been minimized.

Copy link
Author

@chisNaN chisNaN commented Dec 18, 2018

Thanks for your reactivity. So the idea is maybe to wait the next version (of chrome) before applying any changes?

@chisNaN

This comment has been minimized.

Copy link
Author

@chisNaN chisNaN commented Jan 30, 2019

I think we can close this issue
as i confirm it work again with new current Version 72.0.3626.81
(Did not make the test on android though)

@chisNaN chisNaN closed this Jan 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.