Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Safari (MacOs), simple-peer version ? #1594

Closed
froduit opened this issue Mar 14, 2019 · 2 comments
Closed

Issue on Safari (MacOs), simple-peer version ? #1594

froduit opened this issue Mar 14, 2019 · 2 comments

Comments

@froduit
Copy link

@froduit froduit commented Mar 14, 2019

What version of WebTorrent?
Latest from CDN (https://cdn.jsdelivr.net/webtorrent/latest/webtorrent.min.js)
What operating system and Node.js version?
macOS Mojave
What browser and version? (if using WebTorrent in the browser)
Safari 12.0.3
What did you expect to happen?
I expected a video file to play flawlessly like on the other browsers.
What actually happened?
I often get the black player with the error :
Unhandled Promise Rejection: TypeError: Argument 1 ('options') to RTCPeerConnection.createOffer must be a dictionary

I saw (#1550) that it could come from simple-peer, which has been updated since then I think. But still I get the same error.
Everything works fine on Chrome & Firefox (no error at all).
I am using webtorrent from the CND (jsdelivr.net) and I use webtorrent Desktop on Windows server 2016 to seed the files. Does it matter ?

Thank you.

@froduit

This comment has been minimized.

Copy link
Author

@froduit froduit commented Apr 4, 2019

The solution was to get the latest version of webtorrent from the npm folder of the CDN :

<script src="https://cdn.jsdelivr.net/npm/webtorrent@latest/webtorrent.min.js"></script>

and not the one provided on webtorrent.io...

@froduit froduit closed this Apr 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
@webtorrent webtorrent unlocked this conversation Aug 4, 2019
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 4, 2019

Thanks for the issue. I just updated the docs on the site so they use the correct URL: #1682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.