Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Handle Invalid Windows Characters #1618

Open
Jaliborc opened this issue Apr 24, 2019 · 5 comments
Open

Cannot Handle Invalid Windows Characters #1618

Jaliborc opened this issue Apr 24, 2019 · 5 comments
Labels

Comments

@Jaliborc
Copy link

@Jaliborc Jaliborc commented Apr 24, 2019

What version of WebTorrent?

What operating system and Node.js version?
Windows 10, Node 10

What did you expect to happen?
When you download a torrent that contains files with names with invalid characters (colons for example, "The Banana King: Requiem - Episode 4.mp4"), either windows system invalid characters should be translated automatically like most torrent clients do, or there should be
an way in the API to assign each file a different write name individually.

What actually happened?
WebTorrent tries to download the file with the original name. Which fails.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Jul 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 24, 2019
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Jul 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@Jaliborc

This comment has been minimized.

Copy link
Author

@Jaliborc Jaliborc commented Jul 24, 2019

Bump

@stale stale bot removed the stale label Jul 24, 2019
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Jul 27, 2019

This seems reasonable to support. Is there a list of invalid windows characters and the preferred characters to translate them into?

@Jaliborc

This comment has been minimized.

Copy link
Author

@Jaliborc Jaliborc commented Jul 28, 2019

I made an npm module for our internal use that converts all the invalid characters to the most similar we could find.

This file lists all the invalid characters and our suggested translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.