Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCannot Handle Invalid Windows Characters #1618
Open
Comments
This comment has been minimized.
This comment has been minimized.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This comment has been minimized.
This comment has been minimized.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This comment has been minimized.
This comment has been minimized.
|
Bump |
This comment has been minimized.
This comment has been minimized.
|
This seems reasonable to support. Is there a list of invalid windows characters and the preferred characters to translate them into? |
This comment has been minimized.
This comment has been minimized.
|
I made an npm module for our internal use that converts all the invalid characters to the most similar we could find. This file lists all the invalid characters and our suggested translations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of WebTorrent?
What operating system and Node.js version?
Windows 10, Node 10
What did you expect to happen?
When you download a torrent that contains files with names with invalid characters (colons for example, "The Banana King: Requiem - Episode 4.mp4"), either windows system invalid characters should be translated automatically like most torrent clients do, or there should be
an way in the API to assign each file a different write name individually.
What actually happened?
WebTorrent tries to download the file with the original name. Which fails.