Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 8 support #1681

Closed
feross opened this issue Aug 2, 2019 · 1 comment
Closed

Drop Node 8 support #1681

feross opened this issue Aug 2, 2019 · 1 comment
Assignees
Labels

Comments

@feross
Copy link
Member

@feross feross commented Aug 2, 2019

Node 8 is EOL on December 31 (in 5 months from now). This date is earlier than the usual date in April. I believe a special exception was made to EOL Node 8 a bit earlier than normal, just for this version.

If we drop support for Node 8 then we can remove some unneeded dependencies and some hacks in the codebase. I'd like to do that. Folks who need Node 8 can pin their webtorrent version in package.json.

This is part of my overall effort to update and clean up webtorrent dependencies: brave/brave-browser#5490

Some things to do:

  • Remove mkdirp and replace with fs.mkdir(path[, options], callback) with the { recursive: true } option.
  • Remove require('url') (even for fallback) and replace with URL everywhere
@feross feross added the area/node label Aug 2, 2019
@feross feross self-assigned this Aug 2, 2019
feross added a commit to webtorrent/webtorrent-cli that referenced this issue Aug 4, 2019
feross added a commit that referenced this issue Aug 4, 2019
For: #1681
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Aug 4, 2019

0.106.0 is released, without Node 8 support.

feross added a commit that referenced this issue Aug 4, 2019
feross added a commit to webtorrent/webtorrent-hybrid that referenced this issue Aug 4, 2019
@feross feross closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.