Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upProposal: Deprecate `parse-torrent-file` #1732
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
cc @webtorrent/members |
This comment has been minimized.
This comment has been minimized.
|
Voted with a reaction. I invite everyone to do the same. |
This comment has been minimized.
This comment has been minimized.
|
I believe it's unanimous. @feross are you the one merging them? |
This comment has been minimized.
This comment has been minimized.
|
Just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm really happy that WebTorrent is hyper-modular, since it's enabled tons of innovation on top of the core modules. There are so many use cases for these lower-level modules that we never could have anticipated!
That said, sometimes we've gone too far.
In the past,
webtorrent-trackerandbittorrent-trackerwere two separate packages. Now we just havebittorrent-tracker, which was the right move.We also used to have
webtorrent,bittorrent-client, andbittorrent-swarm. Now we've merged them all intowebtorrentsince the others weren't usable on their own.I propose that we deprecate
parse-torrent-fileand merge it intoparse-torrent. The test suites for both are almost entirely identical and it's always better to useparse-torrentinstead ofparse-torrent-file, since it also supports parsing magnet links (just one dep more).Thoughts?