Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Deprecate `parse-torrent-file` #1732

Closed
feross opened this issue Apr 14, 2017 · 4 comments
Closed

Proposal: Deprecate `parse-torrent-file` #1732

feross opened this issue Apr 14, 2017 · 4 comments

Comments

@feross
Copy link
Member

@feross feross commented Apr 14, 2017

I'm really happy that WebTorrent is hyper-modular, since it's enabled tons of innovation on top of the core modules. There are so many use cases for these lower-level modules that we never could have anticipated!

That said, sometimes we've gone too far.

In the past, webtorrent-tracker and bittorrent-tracker were two separate packages. Now we just have bittorrent-tracker, which was the right move.

We also used to have webtorrent, bittorrent-client, and bittorrent-swarm. Now we've merged them all into webtorrent since the others weren't usable on their own.

I propose that we deprecate parse-torrent-file and merge it into parse-torrent. The test suites for both are almost entirely identical and it's always better to use parse-torrent instead of parse-torrent-file, since it also supports parsing magnet links (just one dep more).

Thoughts?

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Apr 14, 2017

cc @webtorrent/members

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Apr 15, 2017

Voted with a reaction. I invite everyone to do the same.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented May 24, 2017

I believe it's unanimous. @feross are you the one merging them?

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Apr 13, 2018

Just merged parse-torrent-file into parse-torrent. Released it as parse-torrent@5.9.0. I also marked parse-torrent-file as deprecated.

@feross feross closed this Apr 13, 2018
@feross feross transferred this issue from another repository Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.