Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upConsider deprecating `webtorrent-hyrbid` and moving `wrtc` into `webtorrent` #1734
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
webtorrent-hybridand theglobal.WEBTORRENT_ANNOUNCEis kind of a hack.The whole reason I created
webtorrent-hybridwas that installing the WebRTC in Node.js package (wrtc) used to cause lots of install warnings/errors for most users at one point in time. If the situation has improved since then, we can just includewrtcdirectly in thewebtorrentpackage and deprecatewebtorrent-hybrid.We can try including
wrtcin one version ofwebtorrentto see how many install errors it causes and if all looks good, then we can eventually deprecatewebtorrent-hybrid.Originally posted by @feross in #1604 (comment)