Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating `webtorrent-hyrbid` and moving `wrtc` into `webtorrent` #1734

Open
feross opened this issue Sep 5, 2019 · 0 comments
Open
Labels

Comments

@feross
Copy link
Member

@feross feross commented Sep 5, 2019

webtorrent-hybrid and the global.WEBTORRENT_ANNOUNCE is kind of a hack.

The whole reason I created webtorrent-hybrid was that installing the WebRTC in Node.js package (wrtc) used to cause lots of install warnings/errors for most users at one point in time. If the situation has improved since then, we can just include wrtc directly in the webtorrent package and deprecate webtorrent-hybrid.

We can try including wrtc in one version of webtorrent to see how many install errors it causes and if all looks good, then we can eventually deprecate webtorrent-hybrid.

Originally posted by @feross in #1604 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.