Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of bittorrent-protocol is breaking the build 🚨 #1743

Closed
greenkeeper bot opened this issue Sep 11, 2019 · 2 comments
Closed

An in-range update of bittorrent-protocol is breaking the build 🚨 #1743

greenkeeper bot opened this issue Sep 11, 2019 · 2 comments
Labels

Comments

@greenkeeper
Copy link
Contributor

@greenkeeper greenkeeper bot commented Sep 11, 2019

The dependency bittorrent-protocol was updated from 3.1.0 to 3.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

bittorrent-protocol is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
  • continuous-integration/appveyor/branch: AppVeyor build failed (Details).

Commits

The new version differs by 2 commits.

  • 0e3b0ec 3.1.1
  • 5a4de2f don't assume 'finish' event binds this automatically

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Sep 11, 2019
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented Sep 11, 2019

After pinning to 3.1.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 11, 2019

This is weird. The tests actually passed. I think Greenkeeper is buggy...

@feross feross closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.