Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change External media player in Mac OS Catalina #1746

Open
NIXOYE opened this issue Sep 16, 2019 · 5 comments
Open

Can't change External media player in Mac OS Catalina #1746

NIXOYE opened this issue Sep 16, 2019 · 5 comments

Comments

@NIXOYE
Copy link

@NIXOYE NIXOYE commented Sep 16, 2019

What version of this package are you using?
0.21.0
What operating system, Node.js, and npm version?
Mac OS Catalina
What happened?
Can't change the external media player
What did you expect to happen?
expected to be able to change the external media player
Are you willing to submit a pull request to fix this bug?
sure?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 16, 2019

Thanks for filing an issue. Can you be a bit more detailed? What exactly happens when you click the button to change the external media player -- does it just do nothing?

Can you try to reproduce this error once more? But this time when it happens, click View > Developer > Developer Tools, select the Console tab and copy-paste all the text into a new comment here.

If you don't see any errors, then please check in one more place! Click View > Developer > Show WebTorrent Process, select the Console tab and copy-paste all the text.

Being able to see that output would help us out very much. Thanks.

@NIXOYE

This comment has been minimized.

Copy link
Author

@NIXOYE NIXOYE commented Sep 17, 2019

Yeah it just doesn't do anything.

Underlying stack: TypeError: Default path must be a string
    at openDialog (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/api/dialog.js:89:15)
    at Object.showOpenDialog (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/api/dialog.js:145:16)
    at Object.showOpenDialog (/Applications/WebTorrent.app/Contents/Resources/electron.asar/common/api/deprecate.js:144:32)
    at /Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/rpc-server.js:370:67
    at EventEmitter.<anonymous> (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/rpc-server.js:249:27)
    at EventEmitter.emit (events.js:200:13)
    at WebContents.<anonymous> (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/api/web-contents.js:342:29)
    at WebContents.emit (events.js:200:13)

    at /Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/rpc-server.js:373:21
    at EventEmitter.<anonymous> (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/rpc-server.js:249:27)
    at EventEmitter.emit (events.js:200:13)
    at WebContents.<anonymous> (/Applications/WebTorrent.app/Contents/Resources/electron.asar/browser/api/web-contents.js:342:29)
    at WebContents.emit (events.js:200:13)```
@no-response no-response bot removed the need more info label Sep 17, 2019
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 18, 2019

Thanks for that stack trace. That will be very helpful. This indeed looks like a bug.

@feross feross added the help wanted label Sep 18, 2019
@hicom150

This comment has been minimized.

Copy link

@hicom150 hicom150 commented Sep 18, 2019

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 18, 2019

Yep, this appears to be a duplicate of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.