Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of end-of-stream is breaking the build 🚨 #1748

Open
greenkeeper bot opened this issue Sep 23, 2019 · 6 comments
Open

An in-range update of end-of-stream is breaking the build 🚨 #1748

greenkeeper bot opened this issue Sep 23, 2019 · 6 comments
Labels

Comments

@greenkeeper
Copy link
Contributor

@greenkeeper greenkeeper bot commented Sep 23, 2019

The dependency end-of-stream was updated from 1.4.1 to 1.4.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

end-of-stream is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/appveyor/branch: Waiting for AppVeyor build to complete (Details).
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 10 commits.

  • ec0b5bd 1.4.2
  • 25b2425 move to tape tests for better debugging
  • 9f811e0 Add Travis CI (#20)
  • 3c3f2c2 Add test of http streams (#21)
  • 5bc1e66 Improve test error asserts (#22)
  • c050dbe Add more tests for eos error state (#23)
  • 69cc1f9 moved the pumpify tests to pumpify
  • d457b83 random -> urandom and some cleanup
  • 52106b0 Add failing pumpify test (#17)
  • 7b53f15 use .destroy to close fs streams

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Sep 23, 2019
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented Sep 23, 2019

After pinning to 1.4.1 your tests are passing again. Downgrade this dependency 📌.

@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented Sep 24, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 2 commits.

See the full diff

@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented Sep 25, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 2 commits.

See the full diff

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Oct 1, 2019

@mafintosh Any ideas why the changes to end-of-stream might have caused webtorrent tests to start failing?

@alxhotel

This comment has been minimized.

Copy link
Member

@alxhotel alxhotel commented Nov 6, 2019

@feross the problem is coming from the multistream module.

And it seems that merging the PR#47 from multistream fixes this issue.

@ezanatta-yapay

This comment has been minimized.

Copy link

@ezanatta-yapay ezanatta-yapay commented Dec 10, 2019

I have this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.