Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAn in-range update of end-of-stream is breaking the build 🚨 #1748
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
After pinning to 1.4.1 your tests are passing again. Downgrade this dependency |
This comment has been minimized.
This comment has been minimized.
Your tests are still failing with this version. Compare changes |
This comment has been minimized.
This comment has been minimized.
Your tests are still failing with this version. Compare changes |
This comment has been minimized.
This comment has been minimized.
|
@mafintosh Any ideas why the changes to |
This comment has been minimized.
This comment has been minimized.
|
@feross the problem is coming from the And it seems that merging the PR#47 from multistream fixes this issue. |
This comment has been minimized.
This comment has been minimized.
|
I have this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The dependency end-of-stream was updated from
1.4.1to1.4.2.This version is covered by your current version range and after updating it in your project the build failed.
end-of-stream is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
Status Details
Commits
The new version differs by 10 commits.
ec0b5bd1.4.225b2425move to tape tests for better debugging9f811e0Add Travis CI (#20)3c3f2c2Add test of http streams (#21)5bc1e66Improve test error asserts (#22)c050dbeAdd more tests for eos error state (#23)69cc1f9moved the pumpify tests to pumpifyd457b83random -> urandom and some cleanup52106b0Add failing pumpify test (#17)7b53f15use .destroy to close fs streamsSee the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot🌴