Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of electron is breaking the build 🚨 #1756

Closed
greenkeeper bot opened this issue Oct 9, 2019 · 2 comments
Closed

An in-range update of electron is breaking the build 🚨 #1756

greenkeeper bot opened this issue Oct 9, 2019 · 2 comments
Labels

Comments

@greenkeeper
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 9, 2019

The devDependency electron was updated from 6.0.11 to 6.0.12.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

electron is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build passed (Details).
  • continuous-integration/appveyor/branch: AppVeyor build failed (Details).

Release Notes for electron v6.0.12

Release Notes for v6.0.12

Features

  • Set the ELECTRON_SKIP_BINARY_DOWNLOAD=1 environment variable to skip electron binary download. #20438

Fixes

  • Fixed Node.js' worker_threads in ELECTRON_RUN_AS_NODE. #20457
  • Fixed a regression in the recentDocuments MenuItem role on macOS. #20409
  • Fixed parsing of paths with .asar in directory name extensions. #20402
  • [deps/uv] fsevents: fix file event reporting (backport: v12.x). #20429
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Oct 9, 2019
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

@greenkeeper greenkeeper bot commented Oct 9, 2019

After pinning to 6.0.11 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Oct 14, 2019

false positive

@feross feross closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.