Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: options to constructor and `add` function should be simpler #180

Open
feross opened this issue Nov 10, 2014 · 1 comment
Open

api: options to constructor and `add` function should be simpler #180

feross opened this issue Nov 10, 2014 · 1 comment
Labels
accepted area/browser area/node help wanted
Milestone
v1

Comments

@feross
Copy link
Member

@feross feross commented Nov 10, 2014

It's currently not clear when an option should be passed to the WebTorrent constructor and when it should be passed to client.download. Consider unifying them if possible, or at least documenting this better.
@feross feross modified the milestone: v1 Apr 21, 2016
@nkittsteiner

This comment has been minimized.

Sign in to view
Copy link

@nkittsteiner nkittsteiner commented May 10, 2016 •
edited

@feross it's seems to me that this issue is no longer needed. I've checked 'client.download' and is deprecated in favor for 'add' method. In the docs client.add have different options for 'opts' parameter. What do you think?
@feross feross added accepted and removed accepted labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted area/browser area/node help wanted
Milestone
  v1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@feross @nkittsteiner
You can’t perform that action at this time.