Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the --remove and --no-quit options #181

Closed
feross opened this issue Nov 10, 2014 · 1 comment
Closed

Eliminate the --remove and --no-quit options #181

feross opened this issue Nov 10, 2014 · 1 comment
Labels

Comments

@feross
Copy link
Member

@feross feross commented Nov 10, 2014

These command line options are not frequently used, and we should be able to infer the right thing to do based on other arguments.

If the user specifies a download location with --out, then never remove the downloaded file. Otherwise, download to /tmp/webtorrent and clean the folder at shutdown and/or startup.

If the user species a streaming option (--vlc, --airplay, etc.) or the http server sees a request, then do nothing when the torrent download is complete. Otherwise, automatically quit WebTorrent when the torrent download is complete.

feross added a commit that referenced this issue Nov 19, 2014
Removed `--remove` and `--no-quit`; replaced w/ inference. Solves #181.
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Nov 19, 2014

Fixed in #184

@feross feross closed this Nov 19, 2014
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.