Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upstrings not supported as input to `client.seed` in node #197
Comments
This comment has been minimized.
This comment has been minimized.
|
Correct, it doesn't seem to be implemented as of yet. See here: https://github.com/feross/webtorrent/blob/master/index.js#L199 |
This comment has been minimized.
This comment has been minimized.
|
No, filenames should be supported. This is a regression. |
This comment has been minimized.
This comment has been minimized.
|
Scratch that. Filenames are supported for |
This comment has been minimized.
This comment has been minimized.
|
This is a first pass at supporting seeding files (specified as string file paths) for client.seed: #209 Still need a separate PR to support seeding folders. |
This comment has been minimized.
This comment has been minimized.
|
I just changed |
This comment has been minimized.
This comment has been minimized.
|
This was fixed and released as 0.17.0 a few days ago. |
This might actually be related to #183, but it's a different error, so I think it warrants a separate issue.
From my quick testing, it seems that the string inputs don't work on
client.seed.Example:
The result is this:
So it looks like it expects an array. No prob, wrapped
__filenameup in an array before passing it intoclient.seed. The result:It really looks like file or path strings aren't actually supported. I also tried on
__dirnamewith similar results. Also with arbitrary files and paths.Here's the version info: