Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on hex info_hash and peer_id everywhere #203

Closed
feross opened this issue Dec 12, 2014 · 4 comments · Fixed by #216
Closed

Standardize on hex info_hash and peer_id everywhere #203

feross opened this issue Dec 12, 2014 · 4 comments · Fixed by #216

Comments

@feross
Copy link
Member

@feross feross commented Dec 12, 2014

As @astro said:

It would be really helpful to have consistent conventions for info_hashes and peer_ids in the Webtorrent scope.

The options are:

Buffers: while binary safe, can't be used as dict keys
Binary strings: not printable, also I'm afraid of any Unicode mangling
Hex strings: printable, safe, my favourite

I also think hex is the way to go. This is a breaking change because before a string peerId was assumed to be 'utf8' and now it will be treated as 'hex'.

First PR out here: webtorrent/bittorrent-tracker#47

feross added a commit that referenced this issue Dec 17, 2014
Fixes #203
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Dec 17, 2014

FYI, @astro

@astro

This comment has been minimized.

Copy link
Contributor

@astro astro commented Dec 17, 2014

You rock!

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Dec 26, 2014

This is released as 0.17.0.

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.