Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upStandardize on hex info_hash and peer_id everywhere #203
Comments
This comment has been minimized.
This comment has been minimized.
|
This is fixed in d1f3925 Additional commits to dependencies: |
This comment has been minimized.
This comment has been minimized.
|
FYI, @astro |
This comment has been minimized.
This comment has been minimized.
|
You rock! |
This comment has been minimized.
This comment has been minimized.
|
This is released as 0.17.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As @astro said:
I also think hex is the way to go. This is a breaking change because before a string
peerIdwas assumed to be 'utf8' and now it will be treated as 'hex'.First PR out here: webtorrent/bittorrent-tracker#47