Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.seed, stream input #215

Closed
ArtskydJ opened this issue Dec 21, 2014 · 3 comments
Closed

client.seed, stream input #215

ArtskydJ opened this issue Dec 21, 2014 · 3 comments

Comments

@ArtskydJ
Copy link
Contributor

@ArtskydJ ArtskydJ commented Dec 21, 2014

It looks like streams are used internally in client.seed().

What about allowing a stream as an input?

@mafintosh

This comment has been minimized.

Copy link

@mafintosh mafintosh commented Dec 21, 2014

me and @feross had this discussion on twitter at some point. the problem with accepting streams as input is that in order to seed you need to be able to "re-read" the input and do random access etc. this means that in order to seed a stream you basically need to load the entire thing into memory (or write it to a tmp file) which kinda defeats the purpose

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Dec 22, 2014

What @mafintosh said :)

@feross feross closed this Dec 22, 2014
@ArtskydJ

This comment has been minimized.

Copy link
Contributor Author

@ArtskydJ ArtskydJ commented Dec 22, 2014

Ok, thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.