Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer coming from DHT for specific torrent? #256

Closed
FLYBYME opened this issue Feb 2, 2015 · 2 comments
Closed

Peer coming from DHT for specific torrent? #256

FLYBYME opened this issue Feb 2, 2015 · 2 comments

Comments

@FLYBYME
Copy link

@FLYBYME FLYBYME commented Feb 2, 2015

How do you know if the torrent that is coming from DHT is for the right torrent?

dht emits peers for any infoHash but torrent.js is not looking if the peer is for this torrent.
https://github.com/feross/webtorrent/blob/master/lib/torrent.js#L190
feross added a commit to webtorrent/torrent-discovery that referenced this issue Feb 2, 2015
@feross
add failing test for webtorrent issue 256
18bfda3 
For webtorrent/webtorrent#256
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Feb 2, 2015

You are correct. This was a bug! I just patched torrent-discovery to only emit peers for the infoHash that is passed to discovery.setTorrent. See: webtorrent/torrent-discovery@bb9e379

Thanks for reporting!
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Feb 2, 2015

And a matching test case: webtorrent/torrent-discovery@18bfda3
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@FLYBYME @feross
You can’t perform that action at this time.