Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airplay Subtitles #262

Open
skalg opened this issue Feb 7, 2015 · 4 comments
Open

Airplay Subtitles #262

skalg opened this issue Feb 7, 2015 · 4 comments
Labels
accepted enhancement good first contribution help wanted

Comments

@skalg
Copy link

@skalg skalg commented Feb 7, 2015

I cannot get subtitles to work on my Apple TV.
I've tried srt, vtt, and i get nothing.

Thanks
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Feb 9, 2015

Support may need to be added to airplay-js. I'm not sure if subtitles are already supported or not.

And we'll need to add support in webtorrent, but that part should be easy.
@feross feross added the enhancement label May 25, 2015
@deamme deamme mentioned this issue Aug 7, 2016
Closed
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Aug 7, 2016 •
edited

This issue should be filed in webtorrent-cli now that that is a separate package.

If someone's looking to fix this, I suggest switching the cli to use https://www.npmjs.com/package/airplayer by @watson since that's what WebTorrent Desktop uses now.
@deamme

This comment has been minimized.

Sign in to view
Copy link

@deamme deamme commented Aug 8, 2016

@feross airplayer by @watson doesn't fix the subtitles issue though?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Aug 8, 2016

No -- it's unrelated. I just think it'd be better to have the CLI using the same package as the Desktop app.
@feross feross added accepted and removed accepted labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement good first contribution help wanted
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@skalg @feross @deamme
You can’t perform that action at this time.