Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the "private" flag in .torrent files #271

Closed
feross opened this issue Feb 17, 2015 · 4 comments
Closed

Respect the "private" flag in .torrent files #271

feross opened this issue Feb 17, 2015 · 4 comments
Labels
good first contribution help wanted

Comments

@feross
Copy link
Member

@feross feross commented Feb 17, 2015

When torrents are marked "private", they should not announce to any source but the tracker (i.e. no DHT, no peer exchange).
@feross feross added the help wanted label Feb 17, 2015
@feross feross mentioned this issue Jul 27, 2015
Closed
@gillesdemey gillesdemey mentioned this issue Aug 16, 2015
Merged
@feross feross closed this in #402 Sep 2, 2015
@rom1504

This comment has been minimized.

Sign in to view
Copy link
Member

@rom1504 rom1504 commented Mar 10, 2016

What about https://github.com/feross/webtorrent-app/blob/c176e3897ac70d55acd099a4f15464fb85e79ed7/renderer/index.js#L34 and https://github.com/feross/instant.io/blob/c8924fe4cea665c938911edf5b7efaa2c4b1e9ab/client/index.js#L15 @feross ?
It sounds like it makes all torrent (even ones which are private) use the default tracker list in instant.io and webtorrent-app.
@rom1504

This comment has been minimized.

Sign in to view
Copy link
Member

@rom1504 rom1504 commented Mar 10, 2016

Maybe webtorrent-app and instant.io should check for the private flag before adding these trackers.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Mar 11, 2016

@rom1504 You're correct. Fixed this directly in webtorrent. Released as 0.84.0.
feross added a commit that referenced this issue Mar 11, 2016
@feross
Ignore WEBTORRENT_ANNOUNCE on private torrents (for #271)
a1aba59
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first contribution help wanted
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@feross @rom1504
You can’t perform that action at this time.