Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `webtorrent` command line executable #28

Closed
feross opened this issue Feb 24, 2014 · 8 comments
Closed

Add `webtorrent` command line executable #28

feross opened this issue Feb 24, 2014 · 8 comments
Labels

Comments

@feross
Copy link
Member

@feross feross commented Feb 24, 2014

Since we're using browserify and we've used the node fs, dgram and net apis with browser-specific shims, webtorrent works in node out-of-the-box. Specifically, the bittorrent client works in node. The webtorrent client will take a bit more work.

We should add an executable so users can do:

$ npm install -g webtorrent
$ webtorrent /path/to/torrent

or

$ webtorrent magnet:?xt=urn:btih:d2474e86c95b19b8bcfdb92bc12c9d44667cfa36&dn=Leaves+of+Grass+by+Walt+Whitman.epub
@feross feross added the enhancement label Feb 24, 2014
@wtfaremyinitials

This comment has been minimized.

Copy link

@wtfaremyinitials wtfaremyinitials commented Mar 4, 2014

What directory of the project do you want the command-line executable in?

@wtfaremyinitials

This comment has been minimized.

Copy link

@wtfaremyinitials wtfaremyinitials commented Mar 4, 2014

Also, do you want the command to add the torrent and launch the normal GUI or be fully command line?

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Mar 5, 2014

@wtfaremyinitials are you implementing this? sweet!

In node, usually this type of thing would go in a bin folder in the root. bin/cmd.js or something like that. Then you add an entry to package.json to declare it. See https://www.npmjs.org/doc/files/package.json.html#bin

Would be awesome if you sent in a PR!

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Mar 5, 2014

Fully command-line, ideally. The normal GUI will assume Chrome is installed and that's not necessarily true. Plus launching Chrome is super heavyweight. Showing the progress in the terminal would be cool.

@shavyg2

This comment has been minimized.

Copy link

@shavyg2 shavyg2 commented May 5, 2014

is this being worked on ?

@wtfaremyinitials

This comment has been minimized.

Copy link

@wtfaremyinitials wtfaremyinitials commented May 5, 2014

I've been super busy with school stuff lately. If nobody else wants to do it, I might be able to find some time to do it in the next week.

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented May 7, 2014

There's actually already a command line client in this repo. It's just a front-end to bittorrent-client, plus an http server. It's almost working, but bittorrent-client needs a bit more work first.

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented May 18, 2014

WebTorrent is now usable as a command-line program, installable via npm. Give it a shot!

$ npm install webtorrent -g
$ webtorrent --help

Closing this issue now.

@feross feross closed this May 18, 2014
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.