Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug logs take too much CPU time #285

Closed
feross opened this issue Mar 18, 2015 · 2 comments
Closed

debug logs take too much CPU time #285

feross opened this issue Mar 18, 2015 · 2 comments
Assignees
@feross
Labels
area/browser bug

Comments

@feross
Copy link
Member

@feross feross commented Mar 18, 2015

Enabling debugging in the browser (with localStorage.debug = '*') kills performance on https://instant.io.

I believe this is mostly due to stringifying huge objects like Buffer/Uint8Array. Let's do something about this.
@feross feross self-assigned this Mar 18, 2015
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Mar 19, 2015

This is done now.
@feross feross closed this Mar 19, 2015
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Mar 19, 2015

And a new version of https://instant.io is deployed with the changes.
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@feross feross

Labels
area/browser bug
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.