Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/debug `browserify-versionify` #286

Closed
feross opened this issue Mar 19, 2015 · 1 comment
Closed

Remove/debug `browserify-versionify` #286

feross opened this issue Mar 19, 2015 · 1 comment

Comments

@feross
Copy link
Member

@feross feross commented Mar 19, 2015

I just saw browserify fail to find browserify-versionify like 1/10 times on @jhiesey's computer. No idea why this is happening, but we've seen others report this issue before. This is the first time I've seen it with my own eyes, though.

We should either fix the issue, or remove browserify-versionify.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Mar 19, 2015

Removed browserify-versionify and just require package.json. Adds ~1.5KB to minified/gzipped file size. Not ideal, but at least it's reliable.

Released as 0.29.4.
@feross feross closed this in fbed043 Mar 19, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.