Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let Client.remove use magnet url #287

Closed
ghost opened this issue Mar 20, 2015 · 2 comments
Closed

let Client.remove use magnet url #287

ghost opened this issue Mar 20, 2015 · 2 comments

Comments

@ghost
Copy link

@ghost ghost commented Mar 20, 2015

Client.remove only seems to work with a infohash at the moment would be great to be able to just throw a magnet url and have it remove it aswell.
feross added a commit that referenced this issue Mar 20, 2015
@feross
test: add tests for client.remove
Loading status checks…
020ffa3 
For #287
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Mar 20, 2015

What makes you think that client.remove is not working? What behavior are you seeing?

I just added tests for client.remove (including with a magnet uri) in 020ffa3 and it appears to work correctly.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Mar 20, 2015

Closing because I think this is working as expected.

@sammuel86 if you think this is still broken, just comment with more info and I'll reopen.
@feross feross closed this Mar 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.