Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when torrentId is http/https url or filesystem path to a torrent file #295

Closed
green13 opened this issue Apr 7, 2015 · 2 comments
Closed

Comments

@green13
Copy link

@green13 green13 commented Apr 7, 2015

Parse-torrent throws error "Invalid torrent identifier" when torrentId is http/https url or filesystem path to a torrent file (string).

webtorrent version 0.30.0

var client = new WebTorrent();
var torrent = client.add(torrentId); // error
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 8, 2015

I cannot reproduce this. We also have tests that verify this is working, so this sounds like an edge case bug . Can you post the http url you are trying to use? (Note: please do not share links to copyrighted content.)

Are you running this in node or the browser? Both http/https and filesystem urls are only supported in node.

@green13

This comment has been minimized.

Copy link
Author

@green13 green13 commented Apr 8, 2015

I mistaked, client.get throws error, not client.add. client.get has parameter torrentid and returns null earlier. This confused me.
I'm running in node.

@feross feross closed this Apr 8, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.