Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'webtorrent seed' doesn't work on Windows ('wrtc' dependency doesn't support Windows) #297

Closed
iadj opened this issue Apr 11, 2015 · 5 comments
Closed

Comments

@iadj
Copy link

@iadj iadj commented Apr 11, 2015

With the 'wrtc' dependency, there's no longer support for running 'webtorrent seed' on Windows as wrtc doesn't have Windows support: node-webrtc/node-webrtc#42

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 20, 2015

@iadj Thanks for reporting. What's the behavior that you're seeing? Does webtorrent throw an error or just fail to seed to web peers?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 20, 2015

I just released a change in bittorrent-tracker 3.4.3 that prevents crashing when the wrtc optional dependency is missing.

@iadj Can you confirm that webtorrent seed now works on Windows?

@feross feross closed this Apr 20, 2015
@iadj

This comment has been minimized.

Copy link
Author

@iadj iadj commented Apr 20, 2015

Yes, it's working fine now! Good job @feross.

@iadj

This comment has been minimized.

Copy link
Author

@iadj iadj commented Apr 21, 2015

@feross, is the wrtc dependency currently active for any certain Webtorrent feature? In case I find other issues while testing on Windows.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 23, 2015

wrtc is needed to connect to web peers. It's used by webtorrent seed and webtorrent download.

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.