Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `wrtc` dependency #303
Comments
This comment has been minimized.
This comment has been minimized.
|
I've opened an issue on Hoping that they agree that this is worthwhile. |
This comment has been minimized.
This comment has been minimized.
|
Good news! As of v0.35.0, In node.js,
|
Currently,
bittorrent-tracker, and thus WebTorrent, depend on thewrtcnpm module.wrtcdoesn't build on some linux and windows systems. There are only prebuilt binaries for some platforms. On the other platforms,wrtctries to build the module from source. This can take a long time and will always fail on systems that aren't set up with a compiler. It doesn't work at all on Windows. And, even though it's anoptionalDependencyit often breaks the whole install.The truth is that
wrtcis not a hard dependency for WebTorrent - only if you want WebRTC support to talk to web peers from node. Withoutwrtc, WebTorrent would just be a normal torrent client in node. If there aren't prebuiltwrtcbinaries for a user's platform, I'd rather have it fail immediately (as anoptionalDependency) without attempting a build from source. This would keep the install fast, and WebTorrent would continue to work just fine for end users (even though they wouldn't be able to talk to web peers).I'm still experimenting with the best way to get WebRTC support in node. Too many people are having problems with
wrtc, so I think I'm going to remove that dependency soon.The good news is that Electron (atom-shell) has built-in support for WebRTC, since it's just Chromium. So it's not that important that every user of the
webtorrentnode program has WebRTC support viawrtc. It's more important that install is fast and works for everyone.