Send "stop" to trackers during shutdown

[feross]

The tracker protocol (and bittorrent-tracker) has a method to tell the tracker that a client is leaving the swarm, so the tracker can remove it's "ip:port" from the list of clients.

From the bittorrent-tracker API:

// stop getting peers from the tracker, gracefully leave the swarm
client.stop()

Let's do this.

[sudoaza]

Is this as simple as calling self.stop() from WebTorrent.prototype.destroy ? or am i missing something?

[feross]

Probably 😄 You want to try your hand at a PR?

[sudoaza]

i will!

UPDATE

:( too n00b for this, i thought we were already using bittorrent-tracker/client and was as simple as calling it.

Anyway, the stop event on the server is being called, check this out

 var tracker = new TrackerServer({ udp: false })

 tracker.listen(function () {
   var port = tracker.http.address().port
   var announceUrl = 'http://127.0.0.1:' + port + '/announce'
   leavesParsed.announce = [ announceUrl ]
 })

 tracker.on('stop', function(addr) {
   console.log('STOP HERE',addr)
 })

 var client1 = new WebTorrent({ dht: false })
 var torrent1 = client1.add(leavesParsed)
 torrent1.on('peer', function () {
   client1.destroy()
 })

[janza]

This seems to already be the case, it's called when torrent is removed

[feross]

@janza @sudoaza You guys are right. There may be a timing issue where the server doesn't get the 'stop' event if the client shuts down too quickly because we don't wait for confirmation. See here. There's no callback to wait for the response.

But I think this is okay. We don't want to delay the process exiting to wait for some slow, overloaded tracker on the other side of the world to respond to us.