Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event 'done' isn't called when there are deselected files #316

Closed
sudoaza opened this issue May 13, 2015 · 2 comments
Closed

Event 'done' isn't called when there are deselected files #316

sudoaza opened this issue May 13, 2015 · 2 comments
Labels
bug

Comments

@sudoaza
Copy link

@sudoaza sudoaza commented May 13, 2015

This checks for all the files to be downloaded instead it should check only for the "selected" files/pieces.
https://github.com/feross/webtorrent/blob/master/lib/storage.js#L597

So when all the wanted files are downloaded the torrent wont be done if there are deselected files.
@feross feross added the bug label May 13, 2015
DiegoRBaquero added a commit that referenced this issue Dec 15, 2015
@DiegoRBaquero
Deselected mark Fix #316
Loading status checks…
39b9475
@feross feross closed this in 0ea039f Dec 28, 2015
feross added a commit that referenced this issue Dec 28, 2015
@feross
Merge pull request #544 from feross/fix-torrent-done
Loading status checks…
6d815f3 
Fix torrent.done state when there are deselected files (fix #316)
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Dec 28, 2015

Released as 0.65.1.
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@sudoaza @feross
You can’t perform that action at this time.