Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect timeout improvements #337

Open
feross opened this issue Jun 1, 2015 · 0 comments
Open

Connect timeout improvements #337

feross opened this issue Jun 1, 2015 · 0 comments
Labels
accepted area/node bug

Comments

@feross
Copy link
Member

@feross feross commented Jun 1, 2015

WebRTC connections take longer than TCP connections, especially on networks with high latency since there's a lot of roundtrips involved (I experienced this firsthand while traveling in Berlin last week).

As a hack, I made the connect timeout 25s for all connections: https://github.com/feross/bittorrent-swarm/commit/e4f67a137c7fd96b4f16aa23bec23352ea5f076e

Ideally, we treat each type of peer differently. 5s for TCP connections. 25s for WebRTC connections.
@feross feross added accepted and removed accepted labels May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted area/node bug
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.