Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMove SHA1 to web worker pool #36
Comments
This comment has been minimized.
This comment has been minimized.
|
Irrelevant now that this module is a node.js command line app. This will definitely be an issue for webtorrent.js, though. |
This comment has been minimized.
This comment has been minimized.
|
@feross would this be useful now, considering this is probably the biggest consumer of the cpu? Substack has a great module for web workers. I am not an expert on web workers but would this perhaps speed up the seeding process? Once support is added for data channels in web workers we could just use webtorrent in a worker, but at the moment this seems like the only process you could offload to the worker. What are your thoughts on this? |
This comment has been minimized.
This comment has been minimized.
|
@piedshag Yeah, this would indeed be useful. The issue is that this module needs to work in node.js and Electron environments too, so there's a bit of complexity involved in supporting Node.js which lacks Web Workers. But we can (and should) do it. |
This comment has been minimized.
This comment has been minimized.
|
Should we close this in favor of #235? It looks like there's more discussion/information there. |
This comment has been minimized.
This comment has been minimized.
|
Thanks |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
The UI currently lags (it's affecting the CSS animations) and I think it's due to SHA1 hashing happening on the main thread. Stick it in a web worker pool.