Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeding fails with an exception when no internet connection is available #366

Closed
jhiesey opened this issue Jul 2, 2015 · 1 comment
Closed

Comments

@jhiesey
Copy link
Contributor

@jhiesey jhiesey commented Jul 2, 2015

I don't expect it to work with no internet, but a more graceful failure would be nice.

$ webtorrent-hybrid seed mydir

ERROR: If you think this is a bug in webtorrent, report it!
=====>                                               <=====
=====>  https://github.com/feross/webtorrent/issues  <=====
=====>                                               <=====
/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/lib/websocket-tracker.js:49
  if (!self._socket.connected) {
                   ^
TypeError: Cannot read property 'connected' of null
    at WebSocketTracker.announce (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/lib/websocket-tracker.js:49:20)
    at /usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/client.js:202:13
    at Array.forEach (native)
    at Client._announce (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/client.js:201:18)
    at Client.complete (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/node_modules/torrent-discovery/node_modules/bittorrent-tracker/client.js:181:8)
    at FSStorage.<anonymous> (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/lib/torrent.js:302:56)
    at FSStorage.emit (events.js:129:20)
    at FSStorage.Storage._checkDone (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/lib/storage.js:657:10)
    at FSStorage.Storage._onFileDone (/usr/local/lib/node_modules/webtorrent-hybrid/node_modules/webtorrent/lib/storage.js:649:8)
    at File.emit (events.js:104:17)
@jhiesey

This comment has been minimized.

Copy link
Contributor Author

@jhiesey jhiesey commented Jul 2, 2015

Looks like I had an old version. Seems fine with the newest on npm

@jhiesey jhiesey closed this Jul 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.