Magnet link with web seed does not work #376

marianobrc · 2015-07-16T06:02:31Z

Hi, i'm trying to make streaming to a HTML5 video tag. Here is my full code:

<!DOCTYPE html>
<html>
<head lang="en">
    <meta charset="UTF-8">
    <title>Web Torrent Player</title>
    <script src="https://cdn.jsdelivr.net/webtorrent/latest/webtorrent.min.js"></script>

</head>
<body style="background-color: black">

    <script>
        var showPlayer = function (){

            console.log('Creating WebTorrent Client..');
            var client = new WebTorrent();
            var magnetUri = 'magnet:?xt=urn:btih:4cb67059ed6bd08362da625b3ae77f6f4a075705&dn=bl001-introduction.webm&tr=http%3A%2F%2Ft.bitlove.org%2Fannounce&ws=http%3A%2F%2Fspaceboyz.net%2F%7Eastro%2Fbitlove-show%2Fbl001-introduction.webm';

            if(!client){
                console.log('ERROR creating WebTorrent Client!');
                return;
            }

            console.log('Adding torrent url..');
            client.add(magnetUri, function (torrent) {
                // Got torrent metadata!
                console.log('Torrent info hash:', torrent.infoHash);

                // Let's say the first file is a webm (vp8) or mp4 (h264) video...
                var file = torrent.files[0];

                // Create a video element
                var video = document.createElement('video');
                video.controls = true;
                document.body.appendChild(video);

                // Stream the video into the video tag
                file.createReadStream().pipe(video);
            });
        }

        // loads the player
        showPlayer();

    </script>
</body>
</html>

I'm getting different errors on the client.add(..) call, on firefox and chrome:

On firefox 38.0 on Ubuntu, i get this on the console:

"TypeError: a.parsedTorrent.pieces is undefined webtorrent.min.js:2:930"

On chrome 43.0.2357.125 on Ubuntu, i get this other error on the console:

"webtorrent.min.js:2 Uncaught TypeError: Cannot read property 'length' of undefined"

As the client.add(..) call fails, the video tag can't even load.

feross · 2015-07-17T06:52:34Z

Your code sample is out of date. file.createReadStream().pipe(video) doesn't work anymore.

Please update to the latest version of WebTorrent:

npm i webtorrent@latest --save

And update your code sample:

var WebTorrent = require('webtorrent')

var client = new WebTorrent()
var magnetUri = '...'

client.add(magnetUri, function (torrent) {
  // Got torrent metadata!
  console.log('Client is downloading:', torrent.infoHash)

  torrent.files.forEach(function (file) {
    // Display the file by appending it to the DOM. Supports video, audio, images, and
    // more. Specify a container element (CSS selector or reference to DOM node).
    file.appendTo('body')
  })
})

marianobrc · 2015-07-23T17:47:27Z

Hi, i'm not trying to use webtorrent on node.js. I'm trying to use is on
the browser at client-side, including the .js cdn link. Is that working?

Thanks, regards

2015-07-17 3:52 GMT-03:00 Feross Aboukhadijeh notifications@github.com:

Your code sample is out of date. file.createReadStream().pipe(video)
doesn't work anymore.

Please update to the latest version of WebTorrent:

npm i webtorrent@latest --save

And update your code sample:

var WebTorrent = require('webtorrent')
var client = new WebTorrent()var magnetUri = '...'

client.add(magnetUri, function (torrent) {
// Got torrent metadata!
console.log('Client is downloading:', torrent.infoHash)

torrent.files.forEach(function (file) {
// Display the file by appending it to the DOM. Supports video, audio, images, and
// more. Specify a container element (CSS selector or reference to DOM node).
file.appendTo('body')
})
})

—
Reply to this email directly or view it on GitHub
#376 (comment).

feross · 2015-07-24T09:25:58Z

The code sample I pasted above was for the browser, just assuming browserify (which provides the require function). If you're using the script file from the CDN, then you can just delete the first line var WebTorrent = require('webtorrent').

The webtorrent script will set a WebTorrent function on the global window object.

So the new code snippet would be:

var client = new WebTorrent()
var magnetUri = '...'

client.add(magnetUri, function (torrent) {
  // Got torrent metadata!
  console.log('Client is downloading:', torrent.infoHash)

  torrent.files.forEach(function (file) {
    // Display the file by appending it to the DOM. Supports video, audio, images, and
    // more. Specify a container element (CSS selector or reference to DOM node).
    file.appendTo('body')
  })
})

marianobrc · 2015-07-24T16:29:48Z

Hi, thanks for your answer, and your patience.

I'm still getting the same error. This is the complete code now:

<title>Web Torrent Player</title> <script src="https://cdn.jsdelivr.net/webtorrent/latest/webtorrent.min.js"></script>

<script>
    var showPlayer = function (){

        console.log('Creating WebTorrent Client..')
        var client = new WebTorrent()
        var magnetUri = 'magnet:?xt=urn:btih:4cb67059ed6bd08362da625b3ae77f6f4a075705&dn=bl001-introduction.webm&tr=http%3A%2F%2Ft.bitlove.org%2Fannounce&ws=http%3A%2F%2Fspaceboyz.net%2F%7Eastro%2Fbitlove-show%2Fbl001-introduction.webm'

        if(!client){
            console.log('ERROR creating WebTorrent Client!')
            return;
        }

        console.log('Adding torrent url..');

    client.add(magnetUri, function (torrent) {
      // Got torrent metadata!
      console.log('Client is downloading:', torrent.infoHash)

      torrent.files.forEach(function (file) {
        // Display the file by appending it to the DOM. Supports video, audio, images, and
        // more. Specify a container element (CSS selector or reference to DOM node).
        file.appendTo('body')
      })
    })
    }

    // loads the player
    showPlayer();

</script>

It happens on the the client.add(..) call. The callback function does never executes.
Maybe de file.js on the CDN link isn't the right one?
I copied it from github examples.
https://cdn.jsdelivr.net/webtorrent/latest/webtorrent.min.js

Thanks

deamme · 2015-07-25T18:26:34Z

Got the same issue, the callback function does never execute.

deamme · 2015-07-26T21:42:34Z

I've maybe misunderstood something? It works for instant.io torrents (magnet URI) but not normal torrents from other trackers. So just for webtorrents?

feross · 2015-07-26T21:43:09Z

@deamme See https://github.com/feross/webtorrent/wiki/FAQ

deamme · 2015-07-26T21:46:23Z

@feross Thank you!

marianobrc · 2015-07-26T23:00:28Z

I've tryed with the magnet uri of a torrent file that i took from the example torrent files on the repo.
Could you send me a magnet URI compatible with webtorrents to test it?

Thanks

feross · 2015-07-26T23:08:06Z

@marianobrc I confirmed that the BitLove magnet link is not working. Magnet links with web seeds apparently cause WebTorrent to crash. I just confirmed this and wrote a test. Next, I'll fix it.

marianobrc · 2015-07-26T23:14:30Z

@feross if you need any other info let me know. Thanks!

deamme · 2015-07-26T23:49:02Z

@feross Shouldn't it work with http/https links also? Can't seem to get it working, says "invalid torrent identifier".

feross · 2015-07-26T23:59:51Z

@deamme Please open a new issue. This issue thread is already quite long.

feross · 2015-07-27T00:18:32Z

@marianobrc Okay, the issue with the bitlove .torrent should be fixed in webtorrent 0.53.4.


        Add failing test for #376 (Magnet link with web seed fails)


        Fix magnet links with web seed (fix #376)

marianobrc · 2015-07-27T03:42:36Z

Thank you @feross . Where can i get the lastest .js file?
Is it https://github.com/feross/webtorrent/webtorrent.min.js ?

feross · 2015-07-27T07:29:39Z

@marianobrc Yes, that's the latest.

The link is https://github.com/feross/webtorrent/blob/master/webtorrent.min.js

marianobrc · 2015-07-27T21:34:36Z

Hi @feross . I've dowloaded the js and tested again my webpage.

Now i don't see any errors on the console. I only see the following warnings on Chrome, but not in Firefox:

webtorrent.min.js:7: The provided value 'ms-stream' is not a valid enum value of interface XMLHttpRequestResponseType.
webtorrent.min.js:7: The provided value 'moz-chunked-arraybuffer' is not a valid enum value of interface XMLHttpRequestResponseType.

But i still seeing that the callback funcion on the client.add(..) method isn't called, so the video isn't appended to the body. Is it something else that am i missing?

Thanks, regards

feross · 2015-07-27T21:36:07Z

@marianobrc Read https://github.com/feross/webtorrent/wiki/FAQ

marianobrc · 2015-07-27T22:01:54Z

Thanks @feross, i get it now. I've seeded the torrent first using instant.io and then copied that magnet link and it works great!

feross · 2015-07-27T22:12:24Z

@marianobrc Glad you got it figured out!

vikrambarnwal · 2017-01-27T11:32:21Z

i want to store infoHash of torrent after start seeding (after drag & drop a file into browser generated MagnetURI) in mongodb in nodejs using webtorrent.
please help me @feross

feross · 2017-01-27T21:56:41Z

@vikrambarnwal Please don't ask for help in a random issue. Open a new issue.

Nashorn · 2018-04-07T15:44:32Z

Hi, when .torrent file is created in the browser runtime, where are the .torrents stored? On instant.io?

feross closed this Jul 17, 2015

feross reopened this Jul 26, 2015

feross changed the title ~~Error trying to get video streaming on the browser~~ Magnet link with web seed does not work Jul 26, 2015

feross closed this Jul 27, 2015

feross added a commit that referenced this issue Jul 27, 2015

Add failing test for #376 (Magnet link with web seed fails)

eb5fe09

feross added a commit that referenced this issue Jul 27, 2015

Fix magnet links with web seed (fix #376)

cb5c9a4

webtorrent locked as off topic and limited conversation to collaborators May 15, 2018

webtorrent / webtorrent

Sponsor webtorrent/webtorrent

Join GitHub today

Magnet link with web seed does not work #376

Magnet link with web seed does not work #376

Comments

marianobrc commented Jul 16, 2015

This comment has been minimized.

feross commented Jul 17, 2015

This comment has been minimized.

marianobrc commented Jul 23, 2015

This comment has been minimized.

feross commented Jul 24, 2015

This comment has been minimized.

marianobrc commented Jul 24, 2015

This comment has been minimized.

deamme commented Jul 25, 2015

This comment has been minimized.

deamme commented Jul 26, 2015

This comment has been minimized.

feross commented Jul 26, 2015

This comment has been minimized.

deamme commented Jul 26, 2015

This comment has been minimized.

marianobrc commented Jul 26, 2015

This comment has been minimized.

feross commented Jul 26, 2015

This comment has been minimized.

marianobrc commented Jul 26, 2015

This comment has been minimized.

deamme commented Jul 26, 2015

This comment has been minimized.

feross commented Jul 26, 2015

This comment has been minimized.

feross commented Jul 27, 2015

This comment has been minimized.

marianobrc commented Jul 27, 2015

This comment has been minimized.

feross commented Jul 27, 2015

This comment has been minimized.

marianobrc commented Jul 27, 2015

This comment has been minimized.

feross commented Jul 27, 2015

This comment has been minimized.

marianobrc commented Jul 27, 2015

This comment has been minimized.

feross commented Jul 27, 2015

This comment has been minimized.

vikrambarnwal commented Jan 27, 2017

This comment has been minimized.

feross commented Jan 27, 2017

This comment has been minimized.

Nashorn commented Apr 7, 2018