Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHTTP/HTTPS urls doesn't work #387
Comments
This comment has been minimized.
This comment has been minimized.
|
Are you trying this in the browser? Right now http/https urls to .torrent files don't work there because I completely excluded the Most domains will probably not have the CORS headers configured correctly to allow your website to download the .torrent file. Do you think it's worth adding 50K gzipped, almost doubling the size of the webtorrent library for this feature? $ browserify -r http | gzip | wc -c
49400 |
This comment has been minimized.
This comment has been minimized.
|
@feross I see the problem and of course we shouldn't double the size of the library. I'll close this. |
This comment has been minimized.
This comment has been minimized.
|
Actually, maybe this wasn't entirely fair. $ browserify -r buffer | gzip | wc -c
10836
$ browserify -r stream | gzip | wc -c
31852 |
This comment has been minimized.
This comment has been minimized.
|
It could work out then but I don't really see any sites supporting CORS. |
This comment has been minimized.
This comment has been minimized.
|
Actually, I just checked and since we started supporting web seeding, the We'll support it. |
This comment has been minimized.
This comment has been minimized.
|
Released as 0.54.0. |
States in the documentation that
torrentIdcan be one of the following: