Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upconcurrency and possible memory leak? #407
Comments
This comment has been minimized.
This comment has been minimized.
|
What version of WebTorrent are you using?
|
This comment has been minimized.
This comment has been minimized.
|
0.60.0 with node 0.12.7. Is there maybe a limit on the size of torrent? I saw some issues about buffer limits, not sure if that still holds true. |
This comment has been minimized.
This comment has been minimized.
|
Can you share the code that triggers this? I'll take a look.
|
This comment has been minimized.
This comment has been minimized.
|
Cool thanks, here it is: https://gist.github.com/btmdave/1ea4b14b1754b8d7bffe It's not actually doing it now for me as it's no longer downloading (re: #408) |
This comment has been minimized.
This comment has been minimized.
|
Can you give it a try with webtorrent 0.57.0? We made significant code changes in 0.58.0 and I'm curious if that may be the cause.
|
This comment has been minimized.
This comment has been minimized.
|
kk this version works alot better. I was getting memory of 1,800 MB but now it's under 400mb. |
This comment has been minimized.
This comment has been minimized.
|
I'm facing some memory leaks too. I command line, I'm getting this error:
I'm trying to find what change is causing this leak, but there's a lot to look for. While playing with webtorrent's code, I commented all logic to verify existing torrent data. Without it, the error got delayed, and with it, the download doesn't even starts (it ran out of memory while checking data). |
This comment has been minimized.
This comment has been minimized.
|
got similar problem here webtorrent
run on webtorrent 0.71.1 node v0.10.36 on nas (low cpu and memory) 128MB |
This comment has been minimized.
This comment has been minimized.
|
Running on node 4.x and WebTorrent 0.71.4, I have no memory issues. RAM usage hovers around 130mb. But it occasionally rises to 200mb before going back down. I think there's a baseline of RAM usage that can't go away because it's all source code that is Try using a system with at least 500mb of RAM to avoid issues. |
This comment has been minimized.
This comment has been minimized.
|
Going to close this issue as I can't think of an easy solution to get RAM usage consistently below 128mb. If someone has any ideas, feel free to leave a comment. |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
When running in node, it seems that there's some memory leaks. I've setup 10 clients to download and it just climes up to 1.7g and cuts off. Even with only a couple simultaneous downloads the memory just slow climes up over time, is this a known issue or are there any stats for running a higher level of concurrency?