Tests don't work on Windows

[feross]

Got this email from a user:

Hi feross,



I have been looking at the WebTorrent library and I am interested in being a part of it. However I am having some issues getting set up.

This is on windows. Once I have clone the repo and I try npm install it runs but it doesn’t install everything.

I think ran a loop to loop thru the sub directories and run npm install on them.

I got that to work but when running npm test it doesn’t seem to be working correctly.



Output

C:\Users\Shavaunh\Documents\webtorrent>npm test



> webtorrent@0.62.0 test C:\Users\Shavaunh\Documents\webtorrent

> standard && node ./bin/test.js



events.js:85

      throw er; // Unhandled 'error' event

            ^

Error: spawn npm ENOENT

    at exports._errnoException (util.js:746:11)

    at Process.ChildProcess._handle.onexit (child_process.js:1053:32)

    at child_process.js:1144:20

    at process._tickCallback (node.js:355:11)

    at Function.Module.runMain (module.js:503:11)

    at startup (node.js:129:16)

    at node.js:814:3

npm ERR! Test failed.  See above for more details.

Any help would be lovely

Thanks

Without doing any investigation, my guess is that tests don't work on Windows because we're using / instead of path.join all over the tests.

[shavyg2]

So i found the problem and solved it. Just needed to use path.resolve and also do child.spawn("node"...[CMD,....,...]

This is because a windows system doesn't use the shebang so it might not know how to execute a js file. Spawning using node and node will understand how to read this.

Small issue silly as it sounds, is i don't know how to send a pull request.

[josephfrazier]

My curiosity got the best of me and I tried this out in a Windows 10 VM:

It turns out this is a long-standing issue, but cross-spawn-async provides a workaround. I'll be submitting a PR shortly :)